Lychee icon indicating copy to clipboard operation
Lychee copied to clipboard

Apply naming convention for Rights, Capabilites etc.

Open ildyria opened this issue 1 year ago • 4 comments

This PR builds on #1508 so merging this one will automatically merge the previous one.

  • creates a DTO for user rights.
  • renames capabilities with regard to #1481

ildyria avatar Sep 07 '22 10:09 ildyria

And back to the drawing boards. :laughing:

ildyria avatar Sep 07 '22 18:09 ildyria

Codecov Report

Merging #1511 (3b0d491) into master (f905e22) will decrease coverage by 0.42%. The diff coverage is 89.93%.

Additional details and impacted files

codecov[bot] avatar Sep 12 '22 07:09 codecov[bot]

This PR is getting "a bit" bigger than I expected. Sorry @nagmat84

ildyria avatar Sep 12 '22 19:09 ildyria

I am not sure yet if this is 100% merge ready. I tried to cover quite a few of the corner cases. The front-end still depends heavily on the global right to upload instead of per album... but I would rather do those change subsequently.

Nevertheless, as always I expect a lots of complaints of @nagmat84 so here we go for a first round of reviews. :D Hence yes, @nagmat84, this is a review request. ;)

ildyria avatar Sep 21 '22 20:09 ildyria

Rebased on top of #1529

ildyria avatar Sep 26 '22 19:09 ildyria

@nagmat84 I would suggest you have another look. There should not be many changes left to be done hopefully. I tried to go in most corner cases.

ildyria avatar Sep 28 '22 21:09 ildyria

@nagmat84 I tried to cover all your comments. :)

So far, the only part missing is on CAN_EDIT_OWN_SETTINGS.

@kamil4 @qwerty287 @d7415 Enjoy the review. :) https://github.com/LycheeOrg/Lychee-front/pull/320 < also needed.

ildyria avatar Sep 29 '22 12:09 ildyria

Considering closing this, squash and open a new PR in order to have a clean history and remove resolved comments. :')

ildyria avatar Sep 29 '22 14:09 ildyria

Considering closing this, squash and open a new PR in order to have a clean history and remove resolved comments. :')

I don't mind either way. But in case you decide to "restart", I would not review this PR but wait until you have decided.

nagmat84 avatar Sep 29 '22 16:09 nagmat84

Considering closing this, squash and open a new PR in order to have a clean history and remove resolved comments. :')

I don't mind either way. But in case you decide to "restart", I would not review this PR but wait until you have decided.

I'll do that then.

ildyria avatar Sep 29 '22 16:09 ildyria