Lychee icon indicating copy to clipboard operation
Lychee copied to clipboard

Published 20 hours ago • verified publisher icon LycheeOrg

Upgrade to Laravel 9 + switch to Laragear/WebAuthn

Open ildyria opened this issue 1 year ago • 6 comments

ildyria avatar Aug 19 '22 22:08 ildyria

Please keep also in mind that the stream handling with respect to the change from Flysystem v1 to v3 needs changes.

nagmat84 avatar Aug 20 '22 09:08 nagmat84

Please keep also in mind that the stream handling with respect to the change from Flysystem v1 to v3 needs changes.

No worries, I have not forgotten. Do you mind if I let you fix that part while I focus on the WebAuthn problem? :) I can also give a shot to the streams, but I have never worked with them before. But I can try. :)

ildyria avatar Aug 20 '22 09:08 ildyria

Codecov Report

Merging #1469 (096500d) into master (80bbd41) will decrease coverage by 1.01%. The diff coverage is 52.70%.

Additional details and impacted files

codecov[bot] avatar Sep 07 '22 18:09 codecov[bot]

Finally !

ildyria avatar Sep 07 '22 18:09 ildyria

I guess I need at least the upcoming weekend to step through this PR. First, I would like to put my attention on https://github.com/LycheeOrg/Lychee/pull/1368 and https://github.com/LycheeOrg/Lychee/pull/1366 which are a) much smaller and b) longer in the pipeline.

nagmat84 avatar Sep 08 '22 17:09 nagmat84

I guess I need at least the upcoming weekend to step through this PR. First, I would like to put my attention on #1368 and #1366 which are a) much smaller and b) longer in the pipeline.

I would be happy if also #1480 would take priority over this one. :'D

ildyria avatar Sep 08 '22 17:09 ildyria