Lychee
Lychee copied to clipboard
Improve config options
:warning: might be breaking
- Reduce options by removing/determining automatically
- removed logs config completely because it's only used for SQL logs
- other removals are mostly unused options
- removed options that might result in wrong config without real warnings
- add some new env options (like
HASHING_ALGORITHM
)
Codecov Report
Merging #1366 (3b26ba0) into master (bb98373) will decrease coverage by
0.87%
. The diff coverage isn/a
.
Somewhat off-topic, but I've just seen that composer.json still has "name": "lycheeorg/lychee-laravel"
...
@LycheeOrg/reviewers This PR should be reviewed because it contains some new config options that are already listed in the docs. Could you please re-review it?
@nagmat84 I added the session store option back. You still need to approve because you requested changes :)
@qwerty287 There have been some changes with Laravel 9. I would suggest to see if you could rebase this PR on top of https://github.com/LycheeOrg/Lychee/pull/1469 to avoid doing the work twice. :|
Or we can merge this now and see what is conflicting with #1469 :)
I'd merge this first and then look at #1469. I can see what I can do regarding conflicts there, but I'd merge this first.
I guess we are good to merge this one?
From my side yes :)