Lychee icon indicating copy to clipboard operation
Lychee copied to clipboard

Improve config options

Open qwerty287 opened this issue 2 years ago • 2 comments

:warning: might be breaking

  • Reduce options by removing/determining automatically
    • removed logs config completely because it's only used for SQL logs
    • other removals are mostly unused options
    • removed options that might result in wrong config without real warnings
  • add some new env options (like HASHING_ALGORITHM)

qwerty287 avatar Jun 11 '22 17:06 qwerty287

Codecov Report

Merging #1366 (3b26ba0) into master (bb98373) will decrease coverage by 0.87%. The diff coverage is n/a.

codecov[bot] avatar Jun 11 '22 17:06 codecov[bot]

Somewhat off-topic, but I've just seen that composer.json still has "name": "lycheeorg/lychee-laravel"...

d7415 avatar Jun 11 '22 18:06 d7415

@LycheeOrg/reviewers This PR should be reviewed because it contains some new config options that are already listed in the docs. Could you please re-review it?

qwerty287 avatar Aug 25 '22 18:08 qwerty287

@nagmat84 I added the session store option back. You still need to approve because you requested changes :)

qwerty287 avatar Sep 04 '22 12:09 qwerty287

@qwerty287 There have been some changes with Laravel 9. I would suggest to see if you could rebase this PR on top of https://github.com/LycheeOrg/Lychee/pull/1469 to avoid doing the work twice. :|

Or we can merge this now and see what is conflicting with #1469 :)

ildyria avatar Sep 08 '22 15:09 ildyria

I'd merge this first and then look at #1469. I can see what I can do regarding conflicts there, but I'd merge this first.

qwerty287 avatar Sep 08 '22 16:09 qwerty287

I guess we are good to merge this one?

nagmat84 avatar Sep 08 '22 17:09 nagmat84

From my side yes :)

qwerty287 avatar Sep 08 '22 17:09 qwerty287