MGSHDFix icon indicating copy to clipboard operation
MGSHDFix copied to clipboard

Update for Version 2.0.0

Open Ogremair opened this issue 1 year ago • 43 comments

Game has new update which broke MGSHDFix

Ogremair avatar Sep 25 '24 09:09 Ogremair

I can confirm. HDFix is completely borked regardless of "Resolution setting" set in the new menu.

Zonrotan avatar Sep 25 '24 09:09 Zonrotan

I should be able to have a proper look this weekend. It looks like based on quickly looking at the log results that it's mostly resolution and window management stuff that's broken by the update.

Lyall avatar Sep 25 '24 10:09 Lyall

I should be able to have a proper look this weekend. It looks like based on quickly looking at the log results that it's mostly resolution and window management stuff that's broken by the update.

I don't know how to modify it myself but yes. It's only resolution and window management. The update also made the windowed mode option bugged (it resets everytime you reset the games)

MasterDarkseid avatar Sep 25 '24 14:09 MasterDarkseid

also if you can add the option in the ini file to change the mouse sensitivity for mgs2 like mgs3 that would be awesome! thanks by your hard work!!

mben67 avatar Sep 25 '24 17:09 mben67

@emoose @Lyall Just to note for the update, it appears Konami has added 32MB intro logo textures to both MGS2 & MGS3, which surpasses the old 16MB texture buffer size limit that was previously expanded for MGS3 w/ MGSHDFix via https://github.com/Lyall/MGSHDFix/pull/39 image

I'd assume that might mean that they've backported the TextureBufferMalloc stuff which previously prevented #39 from being implemented in MGS2 (and likely upped the vanilla limit from what it was before.)

ShizCalev avatar Sep 25 '24 21:09 ShizCalev

Patiently waiting and looking forward to your update. Do you think it would also be possible to also make the new internal resolution feature actually work past the monitor's max resolution ? They've basically just natively implemented a feature that your mod had the entire time. I'd love to push some crazy 8K IR to clean up all aliasing left in the game, and have it downsample to my 1080p monitor. I'd normally force SGSSAA via Profile Inspector on old games, but sadly it doesn't work with DX11

brad86m avatar Sep 28 '24 07:09 brad86m

@emoose @Lyall Just to note for the update, it appears Konami has added 32MB intro logo textures to both MGS2 & MGS3, which surpasses the old 16MB texture buffer size limit that was previously expanded for MGS3 w/ MGSHDFix via #39 image

I'd assume that might mean that they've backported the TextureBufferMalloc stuff which previously prevented #39 from being implemented in MGS2 (and likely upped the vanilla limit from what it was before.)

Looks like they updated the 9 calls to malloc from 16MB to 128MB limits.

METAL GEAR SOLID3.exe+66B33 - B9 00000008           - mov ecx,08000000 { 134217728 }
METAL GEAR SOLID3.exe+66B38 - FF 15 E22D8300        - call qword ptr ["METAL GEAR SOLID3.exe"+899920] { ->ucrtbase.malloc }
METAL GEAR SOLID3.exe+66B3E - 48 8B F8              - mov rdi,rax

Is it still worth offering a customizable size @ShizCalev?

Patiently waiting and looking forward to your update. Do you think it would also be possible to also make the new internal resolution feature actually work past the monitor's max resolution ? They've basically just natively implemented a feature that your mod had the entire time. I'd love to push some crazy 8K IR to clean up all aliasing left in the game, and have it downsample to my 1080p monitor. I'd normally force SGSSAA via Profile Inspector on old games, but sadly it doesn't work with DX11

Yes, I've just added that as a new feature in the update. You can run the game at an arbitrary internal resolution now.

Lyall avatar Sep 28 '24 23:09 Lyall

Since this update is so big I've put up a version for people to test first before removing the pre-release tag. https://github.com/Lyall/MGSHDFix/releases/tag/v2.3

If you try this, please let me know if it works okay for you. If you run in to any issues, remember to post your MGSHDFix.log file here and I can see what went wrong.

Lyall avatar Sep 28 '24 23:09 Lyall

Game doesn't seem to start without the skiplauncher option set to true, but other than that seems to work at the moment MGSHDFix.log heres a log with it set to false

JohnHargis avatar Sep 28 '24 23:09 JohnHargis

Game doesn't seem to start without the skiplauncher option set to true, but other than that seems to work at the moment

Is this with MGS2 or MGS3? Also you copied over all files from the v2.3 zip right? It now comes with 2 ASI loader DLLs, one for the launcher and one for the games.

Lyall avatar Sep 28 '24 23:09 Lyall

MGS2, sorry, and yes all files copied over. even the readme cause im lazy

JohnHargis avatar Sep 28 '24 23:09 JohnHargis

MGS2, sorry, and yes all files copied over. even the readme cause im lazy

Have you removed d3d11.dll from the game folder, if you had an old version of the fix installed?

Lyall avatar Sep 28 '24 23:09 Lyall

I did not do that, thought i did. Alright well that seems to fix that issue

JohnHargis avatar Sep 28 '24 23:09 JohnHargis

I did not do that, thought i did. Alright well that seems to fix that issue

I'll add a note about that to the release notes for v2.3. No doubt it'll catch more people out!

Lyall avatar Sep 29 '24 00:09 Lyall

MGS3 works like a charm with the new patch, and choosing higher internal resolutions work without a hitch(tried 8k). With MGS2 tho, its as if the game isnt downscaling/outputting to the correct output res, so you cant see everything. an example(this should be outputting to 1440p, with an internal res of 4k): METAL_GEAR_SOLID2_2024-09-28_21-06-19 MGSHDFix.log

Dio141 avatar Sep 29 '24 00:09 Dio141

MGS3 works like a charm with the new patch, and choosing higher internal resolutions work without a hitch(tried 8k). With MGS2 tho, its as if the game isnt downscaling/outputting to the correct output res, so you cant see everything. an example(this should be outputting to 1440p, with an internal res of 4k): METAL_GEAR_SOLID2_2024-09-28_21-06-19 MGSHDFix.log

Just to confirm I am seeing that on my end. I'll look into it. Thanks everyone for the feedback so far!

Lyall avatar Sep 29 '24 00:09 Lyall

Just tried out the new patch, made sure to delete d3d11.dll before copying over the new files. Just about everything works correctly for me, playing at native 1440p, thank you! Here are some notes:

-For MG1/MG2 and MGS3, when choosing "End game" in MG1 or MG2 or "Return to Main Menu" in MGS3, the game will just close and the launcher will not re-open, even if "skip launcher" is set to false. This is not the case in MGS2, where the launcher will come back up. Edit: nevermind, this seems somewhat random as to whether or not the launcher will come back up. -Make sure in the launcher options to set all the resolution options to DEFAULT. Otherwise, it can interfere with what MGSHDFix is trying to do and result in a very strange looking output, it will almost appear as though the image is interlaced. After doing that, MGSHDFix worked perfectly.

LethalPlacebo avatar Sep 29 '24 00:09 LethalPlacebo

konami logo (and etc) skip doesn't seem to work, that's the only issue i've had so far though

OddOttAllen avatar Sep 29 '24 01:09 OddOttAllen

konami logo (and etc) skip doesn't seem to work, that's the only issue i've had so far though

This is working for me on MGS2 and MGS3. It's not supposed to work for MG1/MG2.

LethalPlacebo avatar Sep 29 '24 01:09 LethalPlacebo

Make sure to write down people have to have everything set to default because using the upscalers with each other, Interlaces images like crazy. anyway i will say visual quality between my adjusted mode 1440p vs this is very uhh. well Top is Konami Bottom is mod. https://imgur.com/a/lMqJY0c I dunno Maybe it looks better on a 4K monitor. Weirdly i think their adjusted looks better cause its slightly sharper, Will be using the mod for borderless window'd anyway

LunaRosalie avatar Sep 29 '24 02:09 LunaRosalie

Make sure to write down people have to have everything set to default because using the upscalers with each other, Interlaces images like crazy. anyway i will say visual quality between my adjusted mode 1440p vs this is very uhh. well Top is Konami Bottom is mod. https://imgur.com/a/lMqJY0c I dunno Maybe it looks better on a 4K monitor. Weirdly i think their adjusted looks better cause its slightly sharper, Will be using the mod for borderless window'd anyway

I think image quality appears higher on the Konami version because they implemented FSR, which takes effect when you change the upscaling method from "Original" to "Adjusted" in the launcher. On the other hand, the top image appears more aliased, maybe turning on the adjusted upscaling method disables the built-in MSAA in the game?

LethalPlacebo avatar Sep 29 '24 02:09 LethalPlacebo

konami logo (and etc) skip doesn't seem to work, that's the only issue i've had so far though

This is working for me on MGS2 and MGS3. It's not supposed to work for MG1/MG2.

apologies for not saying what games i was testing, but it was indeed MGS2/3, i don't have MG1/2 installed

OddOttAllen avatar Sep 29 '24 03:09 OddOttAllen

I think image quality appears higher on the Konami version because they implemented FSR, which takes effect when you change the upscaling method from "Original" to "Adjusted" in the launcher. On the other hand, the top image appears more aliased, maybe turning on the adjusted upscaling method disables the built-in MSAA in the game?

It's the illusion of appear higher quality due to the upscaler messing with texture rendering sizes. A couple texture modders (myself included) have noted that enabling FSR causes mipmaps to act as if the screen is rendering at a higher resolution, making textures appear "sharper", to the point of EXTREME overshapening (especially when using high res mods.)

These shots are WITHOUT MGSHDFix 1080p with no FSR: image

1080p WITH 4k upscaling/FSR enabled image

ShizCalev avatar Sep 29 '24 04:09 ShizCalev

I think image quality appears higher on the Konami version because they implemented FSR, which takes effect when you change the upscaling method from "Original" to "Adjusted" in the launcher. On the other hand, the top image appears more aliased, maybe turning on the adjusted upscaling method disables the built-in MSAA in the game?

It's not really higher image quality, a couple texture modders (myself included) have noted that enabling FSR causes mipmaps to act as if the screen is rendering at a higher resolution, making textures appear "sharper", to the point of EXTREME overshapening when using high res mods.

That explains a lot, thank you. The oversharpening does look really bad. That explains the "aliasing" I was seeing, just noise introduced from sharpening.

LethalPlacebo avatar Sep 29 '24 04:09 LethalPlacebo

That explains why its sharper, Yeah i prefer the oversharpen effect, TAA, DLSS and Depth of field, and motion blur and Anything designed to blur the screen is the bane of my existence I want to play video games not simulate damaged eye sight. like i would 100% rather play the bottom image there.

LunaRosalie avatar Sep 29 '24 04:09 LunaRosalie

I just tried the new update and it fixed the ultrawide issue so thank you! What I noticed is that the quality looks really bad when i set it up to 5120x1440 when last time it used to look better

Jamezlap avatar Sep 29 '24 05:09 Jamezlap

I just tried the new update and it fixed the ultrawide issue so thank you! What I noticed is that the quality looks really bad when i set it up to 5120x1440 when last time it used to look better

Make sure you go into the game's launcher settings and set all resolution options to Default/Original.

LethalPlacebo avatar Sep 29 '24 06:09 LethalPlacebo

I just tried the new update and it fixed the ultrawide issue so thank you! What I noticed is that the quality looks really bad when i set it up to 5120x1440 when last time it used to look better

Make sure you go into the game's launcher settings and set all resolution options to Default/Original.

Yes! This definitely works thank you!

Jamezlap avatar Sep 29 '24 09:09 Jamezlap

Deleted d3d11.dll from my game files before installing MGSHDFix v2.3 and now the game is actually rendering at native 1440p and borderless windowed works again! Thank you so much Lyall! <3

brugalman avatar Sep 29 '24 17:09 brugalman

Hello, using test version 2.3 (never tried any previous one) the launcher doesn't seem to honour any of the settings of the 'MGSHDFix.ini' file, like skip intro or windowed mode. Options seem correctly applied in-game though. I tried MG1/MG2, MGS2 and MGS3 and it's the same.

Wronschien avatar Oct 01 '24 12:10 Wronschien