Safe-Renderer icon indicating copy to clipboard operation
Safe-Renderer copied to clipboard

Is Google's gmock required?

Open jeremiah opened this issue 7 years ago • 5 comments

Do we have to ship Google's gmock source code? Isn't this just used for testing? If so, can we ask that those who want to test download gmock themselves? This way we would reduce the number of build dependencies.

jeremiah avatar Jan 11 '18 16:01 jeremiah

You are right: It is included because of testing. Will assign Thomas (system architect) to analyze and give a more solid answer from technical perspective.

ArwedL avatar Jan 11 '18 16:01 ArwedL

That sounds good, if we can distribute as little third party code as possible that limits our exposure to licensing issues and maintenance.

jeremiah avatar Jan 11 '18 18:01 jeremiah

We maybe could connect the google mock as a git submodule (as gmock is also hosted on github). Then it would be still convenient to build with tests without having the sources in the repository. What do you think?

THaarer avatar Jan 12 '18 07:01 THaarer

Sure! That may be an elegant solution. :-) As I say, I want to limit the amount of code we ship but if you're fine with a submodule that would work for me.

jeremiah avatar Jan 12 '18 13:01 jeremiah

Hi @ArwedL & @THaarer & @jeremiah as the test framework is required only if the UNIT_TESTS CMake option is ON, I recommend you to check the ExternalProject CMake module, this can solve remote content at build time, and of course, only if it is required or outdated.

denisacostaq avatar Jun 02 '19 17:06 denisacostaq