DocumenterVitepress.jl icon indicating copy to clipboard operation
DocumenterVitepress.jl copied to clipboard

Published 20 hours ago • verified publisher icon LuxDL

The stable docs link in the README is broken

Open LilithHafner opened this issue 1 year ago • 4 comments

The readme link: https://luxdl.github.io/DocumenterVitepress.jl 301 Redirects to https://luxdl.github.io/DocumenterVitepress.jl/ which 200 redirects to https://luxdl.github.io/DocumenterVitepress.jl/stable/ which returns a webpage with status code 200, but this is the webpage:

Webpage showing 404 error

LilithHafner avatar Mar 10 '24 15:03 LilithHafner

Yeah I think Vitepress is not happy with the symlink. Will investigate...

asinghvi17 avatar Mar 10 '24 15:03 asinghvi17

oh... this is bad. I didn't noticed this extra step. IMO, we shouldn't mess with it, all because we want back the old pattern. And if at all, it should be optional, moving forward we should have the cleanUrls as given by vitepress.

lazarusA avatar Mar 10 '24 16:03 lazarusA

This is purely caused by deploydocs afaict

asinghvi17 avatar Mar 10 '24 17:03 asinghvi17

I guess we can provide a fixer function in deploydocs like so:

https://github.com/JuliaDocs/Documenter.jl/blob/a6f6c0c7e33f4b0c3fab38811ac691d646e2d46c/src/deploydocs.jl#L273-L276

which solves these problems? Not sure if that applies itself at the right time, though.

asinghvi17 avatar Mar 11 '24 13:03 asinghvi17