web-ext-translator icon indicating copy to clipboard operation
web-ext-translator copied to clipboard

Published 20 hours ago • verified publisher icon Lusito

Group issues with AMO/wen-ext lint and web-ext build

Open Lusito opened this issue 6 years ago • 3 comments

It seems, that AMO/web-ext lint complain about duplicate keys in the messages.json, so currently it's not possible to use plain WET_GROUP as key. A suffix needs to be appended.

Also an issue: Comments in the messages.json files are allowed by AMO/web-ext lint, but web-ext build complains about not being able to parse the json files.

I'll try to convince Mozilla to fix both of these, but in case this won't get fixed, I'll have to change a couple of things.

See:

  • https://github.com/mozilla/web-ext/issues/1352
  • https://github.com/mozilla/web-ext/issues/1360

Lusito avatar Aug 24 '18 20:08 Lusito

mozilla/web-ext#1360 is fixed and mozilla/web-ext#1352 has been rejected. So what's the status here?

rugk avatar Nov 04 '18 18:11 rugk

Truth is, as you might have guessed, I am currently very busy with other stuff. Can't promise anything. You're welcome to create pull requests of course :)

Lusito avatar Jan 19 '19 11:01 Lusito

Well… you can also just deprecate "WET_GROUP" in general. personally I like the "comment-based solution" for defining groups better anyway… :smile:

rugk avatar Jan 19 '19 14:01 rugk