random_user_agent icon indicating copy to clipboard operation
random_user_agent copied to clipboard

Bad user agent entry

Open matt-slalom opened this issue 2 years ago • 7 comments

Describe the bug There is one random user agent that has quote marks around it. All other entries do not have quotation marks. This causes problems in some cases with downstream consumers, especially JSON parsers.

To Reproduce

from faker import Faker
from random_user_agent.params import SoftwareName, OperatingSystem
from random_user_agent.user_agent import UserAgent

software_names = [SoftwareName.CHROME.value]
operating_systems = [OperatingSystem.WINDOWS.value, OperatingSystem.LINUX.value]
user_agent_rotator = UserAgent(software_names=software_names, operating_systems=operating_systems, limit=100)
user_agents = user_agent_rotator.get_user_agents()

fake = Faker()


def random_user_agent():
    return {"user_agent": user_agent_rotator.get_random_user_agent()}


temp = set()
i = 0
while i < 1000:
    i = i + 1
    random_agent = random_user_agent()["user_agent"]
    if random_agent.startswith('"'):
        temp.add(random_agent)
for item in temp:
    print(item)

prints:

"Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US) AppleWebKit/534.12 (KHTML, like Gecko) Chrome/9.0.576.0 Safari/534.12"

Expected behavior All user agents should be consistent and not contain quotation marks

matt-slalom avatar Oct 27 '22 23:10 matt-slalom