lime-elements icon indicating copy to clipboard operation
lime-elements copied to clipboard

chore: bump tabulator to 5.x

Open anderssonjohan opened this issue 2 years ago • 2 comments

Work for upgrading limel-table component to use tabulator 5.x where a lot of things in the API have been changed.

Upgrade guide: http://tabulator.info/docs/5.0/upgrade

Identified tasks:

  • [x] callbacks moved to events
  • [x] update sort events to use "output" interface (missing in @types/tabulator-tables and added here https://github.com/DefinitelyTyped/DefinitelyTyped/pull/58857)
  • [x] rename ajax-related props according to upgrade guide
  • [x] make remote load work with the new data loaders
  • [ ] turn off invalidOption warnings when being sure all renamed options are migrated/taken care of (http://tabulator.info/docs/5.0/upgrade#debug)

Review:

  • [ ] Commits are atomic
  • [ ] Commits have the correct type for the changes made
  • [ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • [ ] Chrome
  • [ ] Edge
  • [ ] Firefox

Linux:

  • [ ] Chrome
  • [ ] Firefox

macOS:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Mobile:

  • [ ] Chrome on Android
  • [ ] iOS adjust imports

anderssonjohan avatar Apr 04 '22 09:04 anderssonjohan