lime-elements
lime-elements copied to clipboard
feat(table): adjust row height to custom component
#1522
tell tabulator to check the row height when the custom component have rendered.
Note: this is just a draft because it seems to interfere with Tabulator's vertical VDom when scrolling. The solution works for the initial rows but as soon as more rows are added on scroll (row virtualization) changing the height of these rows while also the VDom code sets the scrollTop makes the table scroll to top over and over again while trying to scroll down to the bottom of the table.
Example without this fix:
Using limel-table with custom components only makes tabulator unaware of the row heights and renders each
.tabulator-row
as 16px because of the measured height based on 2x 0.5rem padding
Review:
- [ ] Commits are atomic
- [ ] Commits have the correct type for the changes made
- [ ] Commits with breaking changes are marked as such
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
- [ ] Chrome
- [ ] Edge
- [ ] Firefox
Linux:
- [ ] Chrome
- [ ] Firefox
macOS:
- [ ] Chrome
- [ ] Firefox
- [ ] Safari
Mobile:
- [ ] Chrome on Android
- [ ] iOS