react-native-media-console icon indicating copy to clipboard operation
react-native-media-console copied to clipboard

Disable doubleTapTime set to -1?

Open coofzilla opened this issue 1 year ago • 4 comments

right now im setting the doubleTapTime to -1 to "effectively" disable the feature where it goes to fullscreen. In the case where a user is spamming seek and I dont want them to keep toggling between fullscreen and not ( our videos are quite long ).

However, I want to make sure this is an intended feature and should the description be updated to reflect that?

coofzilla avatar Aug 14 '24 00:08 coofzilla

Hey @coofzilla. I'm not sure I'm following what's the issue here 🤔

LunatiqueCoder avatar Aug 14 '24 06:08 LunatiqueCoder

so basically,

Double tapping will toggle fullscreen.

I want to disable that behavior, so I set doubleTapTime to -1.

I’m checking if this is the intended way to disable the feature, or if it's just a workaround that might break if the implementation changes in the future.

The current documentation says:

doubleTapTime: Tapping twice within this amount of time in milliseconds is considered a double tap

It doesn’t explicitly mention that setting it to -1 disables the feature.

I want to ensure I’m not relying on something that could change.

Hopefully thats a bit more clear 😅

coofzilla avatar Aug 14 '24 06:08 coofzilla

Oh ok, that's also a good find. I don't remember precisely how it's implemented, but it can definitely be improved.

LunatiqueCoder avatar Aug 14 '24 06:08 LunatiqueCoder

If this is an intended solution; then, perhaps just a documentation change is all thats needed? I can scope out the internal details later

coofzilla avatar Aug 14 '24 21:08 coofzilla