react-native-media-console
react-native-media-console copied to clipboard
Disable doubleTapTime set to -1?
right now im setting the doubleTapTime to -1 to "effectively" disable the feature where it goes to fullscreen. In the case where a user is spamming seek and I dont want them to keep toggling between fullscreen and not ( our videos are quite long ).
However, I want to make sure this is an intended feature and should the description be updated to reflect that?
Hey @coofzilla. I'm not sure I'm following what's the issue here 🤔
so basically,
Double tapping will toggle fullscreen.
I want to disable that behavior, so I set doubleTapTime to -1.
I’m checking if this is the intended way to disable the feature, or if it's just a workaround that might break if the implementation changes in the future.
The current documentation says:
doubleTapTime: Tapping twice within this amount of time in milliseconds is considered a double tap
It doesn’t explicitly mention that setting it to -1 disables the feature.
I want to ensure I’m not relying on something that could change.
Hopefully thats a bit more clear 😅
Oh ok, that's also a good find. I don't remember precisely how it's implemented, but it can definitely be improved.
If this is an intended solution; then, perhaps just a documentation change is all thats needed? I can scope out the internal details later