react-native-media-console icon indicating copy to clipboard operation
react-native-media-console copied to clipboard
verified publisher icon LunatiqueCoder

update installation guide in readme

Open HarwinderSingh15 opened this issue 1 year ago • 2 comments

resolve TypeError: Cannot read property 'COVER' of undefined

If somebody has installed different version of react-native-video. ResizeMode type does not get available in that version

How to reproduce

Try with different version of react-native-video library (without alpha or beta versions)

HarwinderSingh15 avatar Mar 01 '24 09:03 HarwinderSingh15

Hello.

As stated in the docs, we only support beta/alpha versions for now, but indeed, the installation steps should also include it. However, this particular README should be updated:

https://github.com/LunatiqueCoder/react-native-media-console/tree/master/packages/media-console#%EF%B8%8F-note

LunatiqueCoder avatar Mar 01 '24 11:03 LunatiqueCoder

Ok, Then we might need to declare ResizeMode types as devs might using react-native-video for other uses in the same project which can lead to errors.

If you agree on this. I'll raise another PR after that

HarwinderSingh15 avatar Mar 01 '24 17:03 HarwinderSingh15

Closing this in favor of #108

LunatiqueCoder avatar May 30 '24 14:05 LunatiqueCoder