LunarVim
fix : Gitsigns toggle_current_line_blame not showing gitblame not vis…
As mentioned in this issue the gitsing blame isn't showing, that's because the GitSignsCurrentLineBlame ins't set, so the default darkvalue doesn't contrast with the background, as mentioned in this other issue.
Trying to get as close as possible to vscode and using the existing color pallet i put it to gray, now it looks like the images below.
Can you show how does it look for you before this PR?
What terminal emulator do you use with neovim? It's possible that it doesn't support every rgb color and there's no difference between those slight changes of gray.
For me it's visible before this PR and it looks more like vscode.
I'm sorry, looks like that the darkplus version that doesn't work is the one from Lunarvim/Colorschemes which had override my LunarVim/darkplus settings.
And you're right the previous version looks closer to the vscode version, should i close the PR or just change the color ?
The version from Lunarvim/Colorschemes :
This is how it looks like for me with cursorline option enabled (its a little bit harder to read but imo it's fine):
But on your screenshot it's much harder to read. Can you try updating to the latest LunarVim/darkplus commit? (on your line blame that change was on 2022-08-03, but on mine it's 2023-04-03)
should i close the PR or just change the color ?
I think you should just change the color. Currently since GitSignsCurrentLineBlame is not specified, it uses the color of NonText, but this can be changed by gitsigns developers. So to make sure it stays the same regardless of what gitsigns changes, you should make it dark_gray.
This is how it looks like for me with cursorline option enabled (its a little bit harder to read but imo it's fine):
But on your screenshot it's much harder to read. Can you try updating to the latest LunarVim/darkplus commit? (on your line blame that change was on 2022-08-03, but on mine it's 2023-04-03)
The different color is because the screenshot i posted is actually from lunarvim/colorschemes i made a typo there, my apologies. About the commit version, i'm at the last commit in the master branch but idk why the the git blame shows that old commit, actually i coudn't even find this commit at 2023-04-03
should i close the PR or just change the color ?
I think you should just change the color. Currently since
GitSignsCurrentLineBlameis not specified, it uses the color ofNonText, but this can be changed by gitsigns developers. So to make sure it stays the same regardless of what gitsigns changes, you should make itdark_gray.
I commited the changes now it looks as expected :