darkplus.nvim
darkplus.nvim copied to clipboard
Could Identifier highlight support be added?
It seems the highlighting in makefile is not implemented. Here is the picture:
I'm not familiar with lua. In case of bad implementation (there are too many color symbols), I'll appreciate the contribution from developers.
I found the definition of @symbol
, which links to Identifier
. I changed the Identifier
's color into light_blue, and the color seems to be great to me.
Here is the modification:
--- a/lua/darkplus/theme.lua
+++ b/lua/darkplus/theme.lua
@@ -101,7 +101,7 @@ theme.set_highlights = function()
hl(0, "Todo", { fg = c.magenta, bg = 'NONE', bold = true, })
hl(0, "Error", { fg = c.error, bg = 'NONE', bold = true, })
hl(0, "Statement", { fg = c.purple, bg = 'NONE' })
- hl(0, "Identifier", { fg = c.fg, bg = 'NONE' })
+ hl(0, "Identifier", { fg = c.light_blue, bg = 'NONE' })
Is there any consideration to let @symbol
be white? If not, the colorscheme could be updated a little bit.
Oh god, I just realized the treesitter of make is not implemented correctly and lack of some essential highlighting groups. e.g. define is not highlighted
Without treesitter, the highlighting group still links to Identifier
, so I might keep the value.