gfxreconstruct
gfxreconstruct copied to clipboard
Fix recapture trim failure caused by adding usage flag in trim capturing
The problem
While attempting to recapture trim for a particular title's full trace file on the same machine where the full trace was captured, an error related to binding resources to memory arose, leading to playback failure. The root cause was the addition of VK_BUFFER_USAGE_TRANSFER_SRC_BIT/VK_IMAGE_USAGE_TRANSFER_SRC_BIT flags in the trim capture handling. This resulted in a change in memory requirements for some resources, which caused memory binding errors and playback failure.
The solution
The commit fixes the issue through adding the flags into the capturing process and captured trace file to ensuring consistent memory usage across all scenarios (including target title running with capturing, full trace or trim trace playback, and recapturing trace files with or without trim).
Result
Tested the target title with the build of the pull request, the pull request fixed the capture trim issue.