gfxreconstruct icon indicating copy to clipboard operation
gfxreconstruct copied to clipboard

Support Convert Option --include-binaries for Every Data Pointer in All APIs Consistently

Open andrew-lunarg opened this issue 1 year ago • 0 comments

For every meta command, every function, every method, that take a pointer to an opaque blob of memory, give them dumpability.

There is function RepresentBinaryFile on branch https://github.com/andrew-lunarg/gfxreconstruct/tree/andy-enhance-better-d3d12-convert (possibly landed in dev when you read this) which can be used to implement the logic of dumping binaries (or not) easily. See Factored-out RepresentBinaryFile.

"For all APIs" means those using the newer JsonWriter / nlohmann backend rather than the "ascii" method.

See further work in #1345 to expand the options for --include-binaries from two to three.

Users might want only a subset of resources dumped (like only the SPIRV programs) so some filtering mechanism could be added later as more follow-up work.

andrew-lunarg avatar Nov 16 '23 14:11 andrew-lunarg