gfxreconstruct
gfxreconstruct copied to clipboard
All Enumerants of MetaDataType Enum use Command Suffix But Some are not Commands
For example kDriverInfoCommand
of MetaDataType
is purely a bundle of data. It doesn't indicate an action like kFillMemoryCommand
does. This naming likely contributes to the way we talk about metadata blocks as "metacommands" in our speech, in the code, and in docs.
We can transfer over to a different naming like:
...
/// @deprecated Old name for kDriverInfo.
kDriverInfoCommand = 22,
kDriverInfo = 22,
...
If Command
is being used to indicate their relatedness and to avoid name collisions with unrelated constants, we don't need that because this is a C++ 11 enum class which already puts the enumerants inside a MetaDataType
namespace so they are accessed like MetaDataType::kDriverInfo
and MetaDataType::kFillMemoryCommand
.
See framework\format\format.h
.