VulkanTools icon indicating copy to clipboard operation
VulkanTools copied to clipboard

api_dump get proc address should return success if driver returns success

Open davidlunarg opened this issue 5 years ago • 1 comments

ActionRPG on Android calls vkGetDeviceProcAddr for vkGetRefreshCycleDurationGOOGLE and vkGetPastPresentationTimingGOOGLE. Since these are instance functions, they fail.

The gfxreconstruct trace layer passes this call down to the next layer (the driver), which returns success, so the gfxreconstruct layer then returns the address of these functions in the gfxreconstruct layer.

The gfxreconstruct trace layer, strictly speaking, is not behaving correctly, but if the driver allows it, it allows it too, and the app works and can be traced. The api_dump layer (and other layers?) should do the same and not fail if the driver did not fail.

davidlunarg avatar Apr 26 '19 21:04 davidlunarg