lumibot icon indicating copy to clipboard operation
lumibot copied to clipboard

Github actions

Open henrytdsimmons opened this issue 3 years ago • 6 comments

Do you have any interest in someone adding GH actions for running tests/linters etc?

henrytdsimmons avatar Sep 22 '21 15:09 henrytdsimmons

Hey Henry,

Yes we are planning to add this eventually. Would you like to help with the project?

On Wed, Sep 22, 2021 at 11:12 AM Henry Simmons @.***> wrote:

Do you have any interest in someone adding GH actions for running tests/linters etc?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/lumibot/issues/74, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYQK7PE2CCXNBT6OIPFD3UDHW4DANCNFSM5ERR54EA .

-- Robert Grzesik 347-635-3416

grzesir avatar Sep 22 '21 17:09 grzesir

Happy to have a go! I see the tests aren't running at the moment anyway.

henrytdsimmons avatar Sep 23 '21 08:09 henrytdsimmons

Yea, we’re still pretty light on testing right now, planning to make a big push on it soon.

We’re always looking for help improving the library, if you want to help contribute to Lumibot then we should get on a call. You can book a time with me here: https://calendly.com/lumi-rob/30min

On Thu, Sep 23, 2021 at 4:13 AM Henry Simmons @.***> wrote:

Happy to have a go! I see the tests aren't running at the moment anyway.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/lumibot/issues/74#issuecomment-925595141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYQK2P4DTI5WU3W2KKRPDUDLOTZANCNFSM5ERR54EA .

-- Robert Grzesik 347-635-3416

grzesir avatar Sep 23 '21 21:09 grzesir

@henrytdsimmons I would like to pick up this conversation if you are still available. I am starting to find time to add some unit and integration test. Would you still be interested in lending an hand? We could use some experience with this. If so, let me know and we can connect.

neilsmurphy avatar Oct 30 '21 17:10 neilsmurphy

I can definitely help here and there. I'm too busy at the moment to commit a lot of time, however.

henrytdsimmons avatar Nov 01 '21 13:11 henrytdsimmons

OK thanks. I'll reach out early next week when I will be focusing a bit more on testing.

neilsmurphy avatar Nov 06 '21 11:11 neilsmurphy