lumibot
lumibot copied to clipboard
Lumiwealth
`websockets/polygon-api-client` Upgrade
There are a lot of packages that rely on webhooks>=13.0, but because of polygon-api-client, there is limited compatibility with other packages. Would it be possible to update polygon-api-client to 1.14.2 so that lumibot can use a more modern websocket?
lumibot (^3.8.16)
└── polygon-api-client (>=1.13.3)
└── websockets (>=10.3,<13.0)
That sounds like a good idea. Feel free to submit a pull request for this. It needs to be updates in setup.py and requirements.txt
Robert Grzesik
On Wed, Dec 4, 2024 at 8:20 AM Jennings Fantini @.***> wrote:
There are a lot of packages that rely on webhooks>=13.0, but because of polygon-api-client, there is limited compatibility with other packages. Would it be possible to update polygon-api-client to 1.14.2 so that lumibot can use a more modern websocket?
lumibot (^3.8.16) └── polygon-api-client (>=1.13.3) └── websockets (>=10.3,<13.0)
— Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/lumibot/issues/646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYQK7NFFHRCNMDONGT4FL2D36RVAVCNFSM6AAAAABTAE6NDSVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YTONZRHEYTAOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@grzesir
I have added a PR for this. I am migrating the package to poetry.
I will install a fixed polygon-api-client via my own fork, which adds correct versioning. Other than that, all functionality is the same, just works for resolving packages. We can revert to polygon-api-client once they fix their versioning.
I made a comment on the PR. Let’s stay with pip please. Only 2 lines need to be changed in two files, and we need to run the tests to make sure nothing broke.
Robert Grzesik
On Wed, Dec 4, 2024 at 12:59 PM Jennings Fantini @.***> wrote:
@grzesir https://github.com/grzesir
I have added a PR for this. I am migrating the package to poetry.
I will install a fixed polygon-api-client via my own fork, which adds correct versioning.
— Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/lumibot/issues/646#issuecomment-2518158808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYQK5V42LALPRGDCS7WDD2D47JPAVCNFSM6AAAAABTAE6NDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYGE2TQOBQHA . You are receiving this because you were mentioned.Message ID: @.***>
Yeah, I can make a version with Pip. It would be easy to migrate automations in your cicd.yaml to work with poetry. This would make lumibot work much better with modern python packages.
How do i stop getting mails from you guys ??????
On Thu, Dec 5, 2024 at 12:34 PM Jennings Fantini @.***> wrote:
Yeah, I can make a version with Pip. It would be easy to migrate automations in your cicd.yaml to work with poetry. This would make lumibot work much better with modern python packages.
— Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/lumibot/issues/646#issuecomment-2520064685, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIOKVGYHTSVMFHEVPQYRGDT2EA25LAVCNFSM6AAAAABTAE6NDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRQGA3DINRYGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>
You can turn off notifications and control them in GitHub.
Robert Grzesik
On Mon, Dec 9, 2024 at 4:57 AM Syntax-Sorcerer87 @.***> wrote:
How do i stop getting mails from you guys ??????
On Thu, Dec 5, 2024 at 12:34 PM Jennings Fantini @.***> wrote:
Yeah, I can make a version with Pip. It would be easy to migrate automations in your cicd.yaml to work with poetry. This would make lumibot work much better with modern python packages.
— Reply to this email directly, view it on GitHub < https://github.com/Lumiwealth/lumibot/issues/646#issuecomment-2520064685>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/BIOKVGYHTSVMFHEVPQYRGDT2EA25LAVCNFSM6AAAAABTAE6NDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRQGA3DINRYGU>
. You are receiving this because you are subscribed to this thread.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/lumibot/issues/646#issuecomment-2527451616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYQK63F5RTZ6FXYG3PDB32EVSQHAVCNFSM6AAAAABTAE6NDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRXGQ2TCNRRGY . You are receiving this because you were mentioned.Message ID: @.***>
There are many reasons for us to stay with pip right now, and poetry comes with its own set of problems
Robert Grzesik
On Thu, Dec 5, 2024 at 6:34 AM Jennings Fantini @.***> wrote:
Yeah, I can make a version with Pip. It would be easy to migrate automations in your cicd.yaml to work with poetry. This would make lumibot work much better with modern python packages.
— Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/lumibot/issues/646#issuecomment-2520064685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYQK357RELEGJDLN2UPBL2EA245AVCNFSM6AAAAABTAE6NDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRQGA3DINRYGU . You are receiving this because you were mentioned.Message ID: @.***>
I have submitted a PR that only adjusts the necessary files. Out of curiosity, what are the problems you see with poetry?