drainpipe icon indicating copy to clipboard operation
drainpipe copied to clipboard
verified publisher icon Lullabot

Issue #347: Use the binary that added failfast functionality.

Open elvism-lullabot opened this issue 8 months ago • 5 comments

see #347

elvism-lullabot avatar Jun 26 '25 20:06 elvism-lullabot

Thanks for starting this. We probably want to be sure tests pass upstream before merging this!

deviantintegral avatar Jun 27 '25 16:06 deviantintegral

@elvism-lullabot Please provide some testing instructions so someone will be able to test this locally.

  1. How to test Failing using current stable release of Drainpipe.
  2. How to test using the changes here and when a test fails it failsfast.

mrdavidburns avatar Jul 08 '25 18:07 mrdavidburns

@elvism-lullabot let's set failfast default to true so it matches current functionality, in hopes that this is a non-breaking change which they review and merge in faster.... as mentioned in the latest comment. https://github.com/go-task/task/pull/2307#issuecomment-3069647789

mrdavidburns avatar Jul 17 '25 14:07 mrdavidburns

@mrdavidburns I have updated the PR and set the default value of 'failfast' to true.

elvism-lullabot avatar Jul 25 '25 14:07 elvism-lullabot

The checks for Test Binary Installer are failing due to the Taskfile version change, from 3.38 to 3.44.0-failfast-default-true. Please, update the reference in this file to fix it. Thanks!

rabbitlair avatar Sep 04 '25 18:09 rabbitlair