Lullabot
Node version is not specified on DDEV defaults to 20 on local and 18 on Tugboat
When the node version is not specific on the .ddev/config.yml file, it defaults to 20 locally on DDEV, but on Tugboat, it is 18.
Then after running composer install with the node version set on the DDEV config file, you get an update in the init.sh for tugboat
Which means that node version is not sync locally and for Tugboat.
What's interesting is the default config ddev generates has a node version in it. So I guess it would have been manually deleted?
I think it would be fine for us to throw an error if the node version isn't specified in ddev.
What's interesting is the default config ddev generates has a node version in it. So I guess it would have been manually deleted?
Likely yes.
I think it would be fine for us to throw an error if the node version isn't specified in ddev.
@deviantintegral What about just throwing a warning?
Why would you want to not specify the node version? At the least, I would have thought you'd want "auto" (which admittedly our Tugboat config won't do anything with).
https://ddev.readthedocs.io/en/stable/users/configuration/config/#nodejs_version
I think about projects that do not have this for any reason, and then Drainpipe stop working when running composer install or when trying to deploy a Tugboat instance. A warning seems better than breaking a packages installation or breaking a deployment on Tugboat.
I implemented a unique source of truth for the Node JS version to be installed for both Github Actions, DDEV and Tugboat, as part of https://github.com/Lullabot/drainpipe/pull/957. Then, once the pull request was finished, I discovered this one. Can someone review the PR and let me know if the approach implemented is fine? Any feedback is welcome. Thank you!
