drainpipe icon indicating copy to clipboard operation
drainpipe copied to clipboard

Make Taskfile includes optional by default

Open deviantintegral opened this issue 2 years ago • 2 comments

We went to the effort a few years back to support optional taskfile includes in Task: https://github.com/go-task/task/issues/519

However, our default taskfile has all of the files as required!

https://github.com/Lullabot/drainpipe/blob/ee7ef635c34f6c27e3f375f9b79f923f593ea389/scaffold/Taskfile.yml#L5-L12

If we change this, it will allow new developers to bootstrap a site without needing to run composer install first. I've prototyped this on a customer site, and we have new setup steps down to exactly two commands:

ddev start && ddev task build:dev:install

The install command has a dependency on a composer install task as I noted at https://github.com/Lullabot/drainpipe/issues/191.

deviantintegral avatar Feb 02 '24 18:02 deviantintegral

I'm calling this a bug for now, because I think we always intended these to be optional once upstream supported it.

deviantintegral avatar Feb 02 '24 18:02 deviantintegral

just for historical context - these weren't intended to be optional, it was added because the test task was in a different composer package that wouldn't necessarily be present if you'd installed just the production dependencies

justafish avatar Feb 15 '24 13:02 justafish

Closing this as composer install needs to run to bring in task

justafish avatar Aug 14 '24 09:08 justafish