drainpipe icon indicating copy to clipboard operation
drainpipe copied to clipboard

Can PANTHEON_MACHINE_TOKEN be preferred over PANTHEON_TOKEN when running ddev task sync?

Open davereid opened this issue 2 years ago • 3 comments

Most of DDEV uses TERMINUS_MACHINE_TOKEN in it's examples, and at another client project where we had a standardized DDEV config across all developers, we used PANTHEON_MACHINE_TOKEN. I'm trying to understand why the environment variable is named PANTHEON_TOKEN and not the more standard examples we've seen in other projects. Could we prefer a more standard name but provide support for the old value?

davereid avatar Jan 04 '24 19:01 davereid

We probably need to propose this change in drainpipe. https://github.com/Lullabot/drainpipe/blob/d2181df595d551db567186c418307c25efbe735e/tasks/pantheon.yml#L10

mrdavidburns avatar Jan 04 '24 19:01 mrdavidburns

👍 to this! We can also do this as a fallback to still support PANTHEON_TOKEN until the next major version.

deviantintegral avatar Jan 09 '24 17:01 deviantintegral

Yup, we used a fallback to the previous environment name so it worked automatically for existing installs.

davereid avatar Mar 04 '24 18:03 davereid