drainpipe
drainpipe copied to clipboard
Lullabot
Update Selenium images / Fix php-webdriver
Our Selenium images are currently > 1 year old, and are stuck there initially because of https://github.com/instaclick/php-webdriver/issues/118 Newer browsers have dropped support for JSON wire protocol.
- [ ] Fork instaclick/php-webdriver https://github.com/Lullabot/php-webdriver Remaining PR https://github.com/Lullabot/php-webdriver/pull/5
- [ ] Test it with Drupal Core tests
PR to minkphp/MinkSelenium2Driver https://github.com/minkphp/MinkSelenium2Driver/pull/372
I've forked the packages as upstream won't accept the changes. https://www.drupal.org/project/drupal/issues/3240792
Currently blocked on some changes that need making to drupal.org's GitLab CI https://www.drupal.org/project/infrastructure/issues/3418417
Currently working on getting the tests running in Firefox so we can verify that the changes that need to happen to Drupal core for w3c compatibility are validated https://git.drupalcode.org/project/drupal/-/merge_requests/7104
In a project using the :has (https://developer.mozilla.org/en-US/docs/Web/CSS/:has) on a CSS selector, the styles are not applying due to the Chromium and Firefox versions, so I need to update the version of them.
@justafish could you review the changes above we made? (internal PR) and weigh in suggesting whether we should upgrade the images versions on our side or on the drainpipe/dev repo
There's a number of drupal.org issues blocking this still: https://www.drupal.org/project/drupal/issues/3432099 https://www.drupal.org/project/drupal/issues/3421202 https://www.drupal.org/project/drupalci_environments/issues/3377509