drainpipe icon indicating copy to clipboard operation
drainpipe copied to clipboard

ComposerLockDiff fails when PR description contains "#\"

Open hawkeyetwolf opened this issue 2 years ago • 6 comments

The ComposerLockDiff GitHub Actions workflow fails on PRs that have "#\" in the PR description.

In my case, I was trying to print "#2" without GitHub automatically linking to the corresponding issue or PR number 2. So I added a slash in front like this: "#\2", and then the ComposerLockDiff workflow began failing. Changing the PR description to <span>#</span>2 made the workflow begin passing again.

This issue is very similar to #181 (closed): Error in composer-lock diff process when PR description contains new lines. The error is the same:

curl: (22) The requested URL returned error: 400
Error: Process completed with exit code 22.

which happens when executing line 52 in the workflow file: https://github.com/Lullabot/drainpipe/blob/272d2415fc5e8cd08e5dd76ff84ab1372d4ab974/scaffold/github/workflows/ComposerLockDiff.yml#L52

hawkeyetwolf avatar Sep 01 '23 18:09 hawkeyetwolf

cc @deviantintegral

hawkeyetwolf avatar Sep 01 '23 18:09 hawkeyetwolf

I have a similar issue in a client site, but not with #\. In this case I suspect is a code block with an iframe.

penyaskito avatar Oct 10 '23 20:10 penyaskito

There's also an issue causing it to remove \. See in this diff how \\xd2 became \xd2:

image

deviantintegral avatar Oct 28 '23 18:10 deviantintegral

Related: #332 .

deviantintegral avatar Feb 19 '24 19:02 deviantintegral

Is #318 also related?

mrdavidburns avatar Feb 21 '24 17:02 mrdavidburns

It wouldn't surprise me if it's the same section of code causing the problem, but we won't know until someone dives into this.

deviantintegral avatar Feb 21 '24 20:02 deviantintegral