amp-library icon indicating copy to clipboard operation
amp-library copied to clipboard

Published 20 hours ago • verified publisher icon Lullabot

Including form tags

Open bibislayer opened this issue 7 years ago • 7 comments

This PR is for #151 bug, validator-generated.php file based on @AlvaroIT file.

bibislayer avatar Oct 10 '17 14:10 bibislayer

Hi @bibislayer ,

Is the library now supports form tags also?

venkatesh-innoppl avatar Mar 28 '18 13:03 venkatesh-innoppl

@venkatesh-innoppl Yes integrated form validator.

bibislayer avatar Mar 28 '18 14:03 bibislayer

@bibislayer ,

I have cloned the latest AMP library and when I use it on my Drupal site, still the form tags are removed from the HTML. Can you correct me if I am doing anything wrong?

venkatesh-innoppl avatar Mar 28 '18 14:03 venkatesh-innoppl

Lullabot haven't merged my pull request, you can create fork on your git and do this change on your fork

bibislayer avatar Mar 28 '18 14:03 bibislayer

@bibislayer ,

Can you provide a patch for the changes you made?

venkatesh-innoppl avatar Mar 28 '18 19:03 venkatesh-innoppl

@bibislayer,

I have used the code changes from your commit and the form tag is not removed this time.

But I am still facing few issues like amp form extension script is removed when verifying page source and action attribute on form tag is being removed. So could you please correct me if I am wrong?

venkatesh-innoppl avatar Mar 29 '18 12:03 venkatesh-innoppl

Can we merge this please ?

red1 avatar Jul 27 '18 12:07 red1