amp-library icon indicating copy to clipboard operation
amp-library copied to clipboard

forms are excluded

Open obeyer opened this issue 9 years ago • 14 comments

after converting to amp html, forms are discarded from the document. But forms are now supported in AMP. Are you planning on fixing it? also, script, which is supposed to process forms, is excluded from the page as well

obeyer avatar Nov 12 '16 11:11 obeyer

I was trying to generate a new validator-generated.php file. validator-generated.php.zip Its working for my simple form, but maybe for your one it wont work... I will try to generate a better one but im a noob in this field...

AlvaroIT avatar Nov 24 '16 17:11 AlvaroIT

@sidkshatriya are you still working on this project? my colleague has his prs opened since September. also, google amp project keeps shipping new features, but they are not supported. Are you planning on updating it?

obeyer avatar Dec 01 '16 22:12 obeyer

@AlvaroIT are you officially working on this project, or you just a contributor?

obeyer avatar Dec 01 '16 22:12 obeyer

Thanks for reaching out @obeyer ! I'm currently not working on this project. Yes, there have been some changes to the Google AMP specification in the interim and this library has not changed to accommodate them. It would require some effort to bring things on par with the canonical specification.

@sebastianbenz might be able to provide some guidance on how to proceed from here.

sidkshatriya avatar Dec 02 '16 04:12 sidkshatriya

Hi! @obeyer I'm not working on this project and i'm not a contributor, i'm just an user of the library. I needed to use the forms in amp, so I took some rules from the prototype.ascii 315 revision, and I built a new validator-generated.php file.

AlvaroIT avatar Dec 02 '16 10:12 AlvaroIT

@sebastianbenz sidkshatriya gave your name to provide some guidance on how to proceed from here. Is it gonna be any future work on this? Should I open pull requests to this rep, or should I just extend the library and make my own changes my own?

obeyer avatar Jan 19 '17 23:01 obeyer

@obeyer I am not currently working on the amp-library, sorry.

sidkshatriya avatar Jan 20 '17 19:01 sidkshatriya

@sebastianbenz hey! I just saw you merged 6 commits today. Does it mean that this project is not abandoned anymore? thx!

obeyer avatar Feb 08 '17 22:02 obeyer

Sorry for the silence. I'm looking for a way to keeping this alive.

On Wed, Feb 8, 2017 at 10:04 PM Olena Beyer [email protected] wrote:

@sebastianbenz https://github.com/sebastianbenz hey! I just saw you merged 6 commits today. Does it mean that this project is not abandoned anymore? thx!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Lullabot/amp-library/issues/151#issuecomment-278476847, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXOONphWkJe5kc5lfBweheBcCKGrcTRks5rajwEgaJpZM4KwY__ .

sebastianbenz avatar Feb 08 '17 22:02 sebastianbenz

is there any updates on integrating form option in this AMP class?

genextwebs avatar Feb 10 '17 14:02 genextwebs

@genextwebs we can look into it. If you have some free time and coding skills, you can improve the library and create a pull request against the library.

SGudbrandsson avatar Mar 14 '17 13:03 SGudbrandsson

I also need forms to be included in generated AMP HTML. Does anyone have a local solution that they are using? If you share that, perhaps it would help everyone else until there is an official solution in this repository.

echosa avatar Apr 03 '17 15:04 echosa

maybe, we can simple not cut 'form' tag. I want add right form with action-xhr, but this library cut it((

alfaq avatar May 18 '17 11:05 alfaq

Hi All,

Anyone found a solution to include form tags in AMP HTML?

venkatesh-innoppl avatar Mar 28 '18 13:03 venkatesh-innoppl