Colorify.js icon indicating copy to clipboard operation
Colorify.js copied to clipboard

Why using id ?

Open Shuunen opened this issue 9 years ago • 4 comments

Hi :)

All is in the title, why using id on line 29 : https://github.com/LukyVj/Colorify.js/blob/master/scripts/colorify.js#L29

And in the examples in doc : image image image

Regards.

Shuunen avatar Nov 29 '16 15:11 Shuunen

Hey, thanks for the issue. Where ? For each gradient ?

Just because it makes sense to me. But happy to discuss about it :)

LukyVj avatar Nov 29 '16 15:11 LukyVj

yes i'm just wondering :) each call to colorify should have an id ?

Shuunen avatar Nov 29 '16 15:11 Shuunen

Ok so, I will have to respond to that a bit later. I did this project nearly 1 year ago, and I barely put my hands in the code after that :p

There were a V2 in it's way, but I stopped developing it. I have to first dig in my code, and then I'll respond.

But so far, what I can say is I target each 'gradient's target' with ID's.

LukyVj avatar Nov 29 '16 15:11 LukyVj

ok :p

it's not a big deal, I was just curious,

Thanks for your lib anyway :+1:

Shuunen avatar Nov 29 '16 15:11 Shuunen