Luke Towers

Results 510 comments of Luke Towers

@goldmont I'm not sure I'm comfortable with this approach. This also bypasses the check for a conflicting property and could have unintended side effects. IMO if a developer is going...

> I would argue that specifying override:true is explicit enough... I disagree, it encourages developers to always set it. The point of the helper method is to have this error...

Closing for now, will re-open if anyone has anything else to add to the discussion.

@austinderrick no, that's just the base version that we require. Composer should be pulling in the latest version that meets those requirements (i.e. `2.*`). What does `composer show wikimedia/minify` return...

For future reference, @jaxwilko's JS for the event stream handling ```js const response = await fetch(window.location.href, { method: 'POST', headers: { 'Accept': 'text/event-stream', 'X-Requested-With': 'XMLHttpRequest', 'X-WINTER-REQUEST-HANDLER': 'onInstallPlugin', 'X-WINTER-REQUEST-PARTIALS': '', 'X-CSRF-TOKEN':...

@coderabbitai review

@bennothommo it's possibly because of the use of `post()` in the Repeater FormWidget without processing it through the individual FormWidget's getLoadValue(), probably here: https://github.com/wintercms/winter/blob/87557b431cfacff68dfabf57f99920c51b3950da/modules/backend/formwidgets/Repeater.php#L354

@mjauvin my guess would be for widgets & fields that are using dependsOn, or anything that uses AJAX to populate values, like dropdown options or something.

I'll have to play around with it, hopefully this Wednesday.

@goldmont what exactly are you expecting to happen?