Luke Towers

Results 512 comments of Luke Towers

Can I have a point form list of each individual feature that this plugin adds to plan how to best integrate it with the core?

@matteotrubini I currently don't have any time to do it myself, but if someone put together a PR I would be more than happy to review it.

@matteotrubini @toughdeveloper @panakour @lthurston @maartenmachiels FYI: this plugin's functionality will shortly be included in the core by default thanks to some sponsorship from @beckandstone. See https://github.com/octobercms/october/pull/5231. Please test out that...

@maartenmachiels nope! If a site is using a plugin that provides the `| resize()` filter already, then the plugin's definition would override the system definition, so the behaviour would remain...

@matteotrubini that would certainly be doable, I'll see if I can whip something up. It's a bit tricky because the new functionality supports remote disks, but I'll see what I...

@toughdeveloper I would agree with that process, although I would remove the plugin from the marketplace when the functionality first releases, it's not going to remove it from any existing...

Is it really necessary to change the class imports back to Illuminate or is it just required to make the booted() vs boot() change? This should also be submitted to...

I don't think this plugin should be actively deleting any files or code if it can help it.

@bennothommo 😂 I meant moreso that we shouldn't be deleting files automatically without even allowing the user to make the decision. Explicitly triggered deletion is fine.