Luke Towers comments

Results 510 comments of


                                            Luke Towers

Fix/ux messages when smtp is not configured in backend

My thoughts are that we should just avoid all of the extra complexity added here and just add extra handling to the system error handler to adjust the message that's...

Fix/ux messages when smtp is not configured in backend

The error messages would be similar @mjauvin, this PR is just to transform opaque and unhelpful core mailer error messages into more actionable advice. Reviewing it more though I'm not...

[1.2] Control system assets through Mix

Ooof, not going to accept in 1.2.0, but will review for 1.2.1. Pretty sure this would crash GitHub in the browser if I tried to include these changes in my...

Add mail template/layout/partial clear command

What I would prefer is removing the reliance on the DB tables entirely, which we may be able to do now with the new ArraySource trait in Storm, and then...

Improve form repeaters

@AIC-BV submit that as a separate issue please, ideally with a PR to the wintercms/wn-test-plugin demonstrating the issue.

Calling partial() as a function to check for the existence of a partial fully executes the partial

@bennothommo yeah, that's what I was thinking, something like `partialExists()`, `pageExists()`, etc

Static Pages 2.0.2 on Winter 1.2.0 - Unable to add global "this" as the runtime or the extensions have already been initialized.

How are you changing the language? Changing the language to FR on https://spatialmedia.ca/fr doesn't trigger the issue.

Static Pages 2.0.2 on Winter 1.2.0 - Unable to add global "this" as the runtime or the extensions have already been initialized.

@az-vm yes please, we'll need to see it to check what's triggering the issue in your case.

Static Pages 2.0.2 on Winter 1.2.0 - Unable to add global "this" as the runtime or the extensions have already been initialized.

I don't see the error on any of the pages, what triggers it?

Static Pages 2.0.2 on Winter 1.2.0 - Unable to add global "this" as the runtime or the extensions have already been initialized.

@az-vm I have not had a chance to yet, no. @Kuse-GmbH why are you putting Twig inside of two `==` section separators?