nbn-upgrade-map icon indicating copy to clipboard operation
nbn-upgrade-map copied to clipboard

Breakdown lost some addressess?

Open Jorvanus opened this issue 1 year ago • 13 comments

Surely, there aren't just addresses that aren't there anymore? This doesn't look quite right.

image

Jorvanus avatar Feb 16 '24 08:02 Jorvanus

Hmmmm that is really strange, I think something changed because on all the recent commits addresses are getting deleted.

I have paused the run but will need to investigate to find the root cause.

LukePrior avatar Feb 19 '24 04:02 LukePrior

Not sure if @lyricnz has any idea but there haven't been any major changes on our end so looks like something might have changed on the NBN side?

LukePrior avatar Feb 19 '24 04:02 LukePrior

Could this be due to several of the garbled LocIDs being trimmed? I have noticed between the 13/1 and 11/2 locations that had Loactions without a LocID infront have disappeared from the map. have attached photos for reference

image

image

captbonus avatar Feb 27 '24 07:02 captbonus

Could this be due to several of the garbled LocIDs being trimmed? I have noticed between the 13/1 and 11/2 locations that had Loactions without a LocID infront have disappeared from the map. have attached photos for reference

image

image

Yeah, and if you plug that address into NBN, it acknowledges the address, but says more work needs to be done for this site to be connected.

All the ones I had a look at, all looked like sensible removals to me, as they don't have any active NBN connections to them.

Jorvanus avatar Feb 27 '24 07:02 Jorvanus

Looking through the records while a lot of the addresses getting removed are ones without a valid LocID, some do have valid IDs.

LukePrior avatar Feb 27 '24 08:02 LukePrior

The script should be using the listed locID in the results file and just querying NBN for updated details.

NBN has updated their autocomplete API to be less generous with matching it seems but I'm not sure why we are seemingly redoing this search...

LukePrior avatar Feb 27 '24 08:02 LukePrior

Ok this is interesting it's a 404 error: https://github.com/LukePrior/nbn-upgrade-map/actions/runs/7946125610/job/21693534967

LukePrior avatar Feb 27 '24 08:02 LukePrior

I think it has to do with extended_get_nbn_loc_id

LukePrior avatar Feb 27 '24 08:02 LukePrior

I don't know if it's blocking us or something else because it works on reqbin, but not locally image

https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k

curl -X GET https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k -H "Referer: https://www.nbnco.com.au/"

Can anyone confirm if this is same for them.

LukePrior avatar Feb 27 '24 09:02 LukePrior

Not sure how you want me to test, but link doesn't work, and that line, gives me error in powershell.

That LOCID does work on the script I used to run myself. irm -Headers @{'referer'='https://www.nbnco.com.au/'} https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k | fl

timestamp : 1709024991023 servingArea : @{csaId=CSA300000010073; techType=WIRELESS; serviceType=Fixed wireless; serviceStatus=available; serviceCategory=brownfields; rfsMessage=Jul 2013; description=WCA-Willowmavin} addressDetail : @{latitude=-37.30807800000001; longitude=144.8932779; reasonCode=FW_SA; serviceType=Fixed wireless; serviceStatus=available; techType=WIRELESS; ee=False} addressSplitDetails : @{address1=150 High Park Rd; locality=Forbes; state=VIC; postcode=3764}

Jorvanus avatar Feb 27 '24 09:02 Jorvanus

image

Jorvanus avatar Feb 27 '24 09:02 Jorvanus

I've set it to rerun, seems the failing addresses have been fully removed from NBN so I guess not too much of an issue.

I think when the suburbs get updated again it will try to add them back with their new locID if available.

https://github.com/LukePrior/nbn-upgrade-map/actions/runs/8062401331/job/22022041834

LukePrior avatar Feb 27 '24 09:02 LukePrior

Will revisit in a few weeks but hopefully it should stabilise, once it does can look into adjusting stats

LukePrior avatar Feb 27 '24 09:02 LukePrior