nbn-upgrade-map icon indicating copy to clipboard operation
nbn-upgrade-map copied to clipboard

Occasional issue when selecting older data in map view

Open lyricnz opened this issue 2 years ago • 1 comments

From #293 #295 etc.

It's sometimes possible to see errors when navigating old history. For example, selecting the second-oldest Bli-Bli date gave me this:

image

The 404 URL is https://raw.githubusercontent.com/LukePrior/nbn-upgrade-map/7473d0340b2c0903276f1ecce2e3a10c3a35061f/results/QLD/bli-bli.geojson

And the commits URL is https://api.github.com/repos/LukePrior/nbn-upgrade-map/commits?path=results/QLD/bli-bli.geojson which does include 7473d0340b2c0903276f1ecce2e3a10c3a35061f

Are we using the wrong field in the JSON? (maybe commits direct to master, vs commits on a PR??)

lyricnz avatar Nov 07 '23 21:11 lyricnz

The history page for that suburb https://github.com/LukePrior/nbn-upgrade-map/commits/main/results/QLD/bli-bli.geojson also shows the commit, but it looks like it deleted all these files

https://github.com/LukePrior/nbn-upgrade-map/commit/7473d0340b2c0903276f1ecce2e3a10c3a35061f

Maybe we need to special-case this sha out of the list? I don't know of another way to identify such case.

lyricnz avatar Nov 07 '23 21:11 lyricnz

Doesn't seem to have resolved, further investigation required.

LukePrior avatar Aug 29 '24 16:08 LukePrior

Now it's fixed

LukePrior avatar Aug 31 '24 06:08 LukePrior