tracing-bunyan-formatter icon indicating copy to clipboard operation
tracing-bunyan-formatter copied to clipboard

Allow lib to build for all targets/platforms

Open Bayernatoor opened this issue 1 year ago • 1 comments

This addresses: #12

PR Adds a hostname feature which activates gethostname dependency and gates it's usage. It adds a #[derive(Default)] to the BunyanFormattingLayer struct so that the default value (<no_hostname>) of field HOSTNAME can be used if the hostname feature is NOT enabled.

This does not change the API and allows the lib to build for any target. It does not allow user to set a hostname (would likely require a change in the public API?)

Let me know if this can be improved/changed in any way.

Bayernatoor avatar May 26 '24 10:05 Bayernatoor

@LukeMathWalker, could you please take a look on this PR?

Bakrog avatar Jul 12 '24 04:07 Bakrog

Just a heads up that I've been using my own fork with this change for the past 5 months with no issues.

Bayernatoor avatar Nov 26 '24 14:11 Bayernatoor