Luca Palmieri

Results 278 comments of Luca Palmieri

> another thought: it probably makes sense to limit the number of entries per category to some degree. e.g. if we already have 15 entries for category X then adding...

I think we're good to go if we figure out a "minimum number of recent downloads" number. Based on the recent changes to crates.io, I think 2000 is a good...

We can raise it to 4k, but I wouldn't go any further as "the first line".

There should be a clear differentiation between a client-generated request id and a server-generated request id. The lack of support for "use this header as request id" is entirely intentional...

> FWIW, the role of server-generated request ID is the OpenTelemetry trace ID or root span ID. Is that meant to be a question or a statement? 👀 The trace...

What kind of logic are you trying to run?

Hey! You can get the trace id that's associated with the current span using `tracing-opentelemetry`. If you do it from a middleware, you can then inject it into the response...

I think that this can be accommodated without changing the public API of this crate. The strategy I would suggest: - introduce a `hostname` feature, enabled by default, which activates...

Thanks for reporting it! Definitely nasty. Setting the parent to `None` is something we already do elsewhere (https://github.com/LukeMathWalker/tracing-bunyan-formatter/blob/c506eafde6062da628147e64039ad7602ee1de75/src/storage_layer.rs#L112) to prevent this specific issue. Switching to using the `parent()` for an...