Luke D Russell

Results 27 comments of Luke D Russell

This seems to be resolved under [PR571](https://github.com/KMKfw/kmk_firmware/pull/571). I guess the failures have something to do with the somewhat out-of-date dependencies.

We've managed to combine two IOS commands into a single object with extends. See https://github.com/Roshna-Raman/cisco_ios/blob/remotes/origin/f/parser_show_ip_route/vars/get_facts_command_map.yaml which calls both `show ip route` and `show ip route vrf *` to get all...

@paneu I just went through this --signoff thing. Checkout your branch, then `git commit --amend --signoff`, then push again.

In my playbooks I use the jinja list filter to iterate, which I think proves your point.

``` git checkout your-branch git reset HEAD~1 git commit -m “your message” -s git push —force ``` https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for If you have more than one commit you’re probably best off editing...

> ...there should not be a "manually change" step unless something changed on Black's side. I distinctly remember Black's auto-fixer handling this due to the stuff in setup.cfg at one...

So this PR seems ready to me. All formatting and tests pass on Win11 with Python 3.10 and Fedora-WSL with 3.9. I've done my best to not change any content...

To Do: 1. Reformat embedded code in docs/ 2. Expand docs/contibutors.md with preference to use `pyproject.toml` for configurations. 3. Update Readme.md to remove the sentence about quotes.

I've not forgotten this PR, I just haven't been able to give it my attention. Next week I'll be between $Jobs so I'll be able to get it across the...