LLGL icon indicating copy to clipboard operation
LLGL copied to clipboard

Fix some warnings under `/W4`

Open duckdoom4 opened this issue 1 year ago • 1 comments

title

duckdoom4 avatar Feb 26 '24 13:02 duckdoom4

Sorry for the late reply. I'll address your pointers. I found some more warnings, so I might add some more fixes before that though. Bit bussy today so I'll try to find some time later

duckdoom4 avatar Feb 28 '24 15:02 duckdoom4

Do you still intend to update this PR or can we close this one since it doesn't compile on some platform configurations?

LukasBanana avatar Apr 05 '24 01:04 LukasBanana

Ah right, forgot about this one. There are still some other warnings so I would like to get them fixed at some point.

That said I think the warnings in this PR have been fixed by you already right? So I can always make a new PR later. I'll leave that up to you.

duckdoom4 avatar Apr 05 '24 06:04 duckdoom4

Closing since the warnings in this PR have been addressed in separate commits. Feel free to open a new PR if you have new fixes.

LukasBanana avatar Apr 07 '24 16:04 LukasBanana