Lukas Audzevicius

Results 44 comments of Lukas Audzevicius

Hi @kjetilho, there seems to be a spec test that is failing currently on your PR. The log is pointing at the following file: `rspec ./spec/unit/puppet/provider/iptables_spec.rb:340 # iptables provider when...

Hey @jan-win1993, this looks like a solid change 👍. However, some issues need to be addressed before it can be merged. Firstly, it seems like our unit testing is not...

Happy to see some activity on this PR. Apart from the current issue, there also seem to be conflicts between the PR and main. This is probably due to some...

Hi @jan-win1993. It seems like this PR has been stale for a bit already. We are doing some clean-up around the modules to close unattended PRs. Please let us know...

Hi @neomilium. After careful evaluation of your PR, I'm happy to inform you that we are ready to go ahead and merge it. Thanks for your contribution! We also noted...

This PR will be temporarily reverted until a release can be cut. Then it will be reinstated. This process is done to follow with standard best practices.

Hey @neomilium. We are sorry for this inconvenience but we had to revert your PR in order to follow best practices when releasing a new version of our module, by...

It looks like there is a single failure occurring across all OSs. Something related to change logging. If this issue is fixed, we should have no problem merging this PR.

Hi @omolenkamp, it seems like your PR has been stale for a while. Our team is currently cleaning up our modules and we are looking to address any stale PRs....

Note: https://github.com/puppetlabs/puppetlabs-inifile/pull/481 seems to be a potential fix for this issue. However, lack of engagement might result in the ticket being closed. Posting link here for future reference, just in...