Mopups
Mopups copied to clipboard
LuckyDucko
HasSystemPadding doesn't work
Hi, thanks for the MAUI port of Rg.Plugins.Popup It looks like the HasSystemPadding property from Rg.Plugins.Popup isn't working well.
You can check this by setting HasSystemPadding to true in the LoginPage in the sample project. It doesn't respect the navigationbar and status bar on Android. I haven't tested on iOS yet.
https://github.com/LuckyDucko/Mopups/pull/34 Could solve this issue for now
@AswinPG this is a good idea.
The idea of "system padding" always seemed kinda strange for the popups to use when you could use padding normally instead.
Give me some time to play with keyboard offsets, see if i cant merge these two things together
@LuckyDucko The keyboard issue could be a maui bug. See https://github.com/dotnet/maui/issues/11274
What's the status of this issue? It looks like the KeyboardOffset is computed, but the padding logic has been removed (comparing with Rg.Plugins.Popup), which is quite annoying. Any reason for that?
What's the status of this issue? It looks like the KeyboardOffset is computed, but the padding logic has been removed (comparing with Rg.Plugins.Popup), which is quite annoying. Any reason for that?
Last time I checked the layouting code that was used to set padding for safe area and keyboard was not working in maui that's why I had to use that padding hack pr to soove the safe area issue(hassystempadding). I'll check if the same hack can be applied to keyboard
Ok thanks. I understand the LayoutChildren method wasn't working properly, but the logic should stay the same. So I think the padding should still be computed using SystemPadding and KeyboardOffset (and checking HasSystemPadding and HasKeyboardOffset flags).