YangJie

Results 232 comments of YangJie

Is this one ready to go ? @panbingkun

Without this PR, I tried to run `mvn javadoc:javadoc` and `mvn javadoc:jar` on `master/branch-3.5/branch-3.4`, and they both failed. I think we can initiate the upgrade of `maven-javadoc-plugin` after fixing them...

hmm... IIRC, https://github.com/panbingkun/spark/actions/runs/9458329785/artifacts/1587905559 is generated by `sbt unidoc`, it should not have used `maven-javadoc-plugin`

> > hmm... IIRC, https://github.com/panbingkun/spark/actions/runs/9458329785/artifacts/1587905559 is generated by `sbt unidoc`, it should not have used `maven-javadoc-plugin` > > Yes, that's right. I tested a PR (#46922) that completely removed `javadoc`,...

> If there is some improvement due to the proposed change, which is relevant to how spark uses it, I would be very interested. > > Performance related changes should...

@djspiewak Indeed, it is clear that there are relevant counterexamples in the current Spark repository. However, the Spark developers have taken proactive measures to address this issue, as evidenced by...

> I've retargeted this pull request and updated the commits. I also took a moment to reexamine the test to see what can be done about the binary file. It's...

@djspiewak Could you please rebase this one? I manually restarted the GitHub Action jobs, but it still failed. Thanks