lucca-front icon indicating copy to clipboard operation
lucca-front copied to clipboard

LuModalPanelComponent labels are not updated

Open bastienguillon opened this issue 5 years ago • 0 comments

https://github.com/LuccaSA/lucca-front/blob/8e92ffba275cc8503f165bcb408a70a052528eff/packages/ng/libraries/modal/src/lib/modal-panel.component.ts#L97

The labels displayed in modals footers are not updated if setted in the modal's component ngOnInit method

Example:

@Component({
	selector: 'app-test-dialog',
	template: '<span>Hello world</span>'
})
export class TestDialogComponent implements ILuModalContent, OnInit {
	public title: string;
	public cancelLabel: string;

	constructor(
	) {
		// The cancelLabel WILL be updated if setted here
		this.cancelLabel = "Value setted in the constructor";
	}

	public ngOnInit(): void {
		// The cancelLabel will NOT be updated if setted here
		this.cancelLabel = "Blablabla"
	}
}

bastienguillon avatar Feb 27 '20 16:02 bastienguillon