lucca-front icon indicating copy to clipboard operation
lucca-front copied to clipboard

Published 20 hours ago • verified publisher icon LuccaSA

refactor(empty-states): make title and description optional

Open Supamiu opened this issue 1 year ago • 10 comments

Description

Everything is explained in #2744

closes #2744

Supamiu avatar May 02 '24 06:05 Supamiu

:woman_cook: https://lucca-front.lucca.tech/PR-2774/storybook

LuccaIntegration avatar May 02 '24 07:05 LuccaIntegration

Tests d'interfaces

CCNET-iLucca avatar May 02 '24 07:05 CCNET-iLucca

Will be checked by UI devs once they're back 🙂 I won't merge without making sure they're fine with what I did here.

Supamiu avatar May 03 '24 16:05 Supamiu

Ping @vvalentin-lucca for a review :)

Supamiu avatar May 15 '24 15:05 Supamiu

I'll have a closer look tomorrow, but if the title becomes optional, the section tag should move accordingly.

vvalentin-lucca avatar May 15 '24 15:05 vvalentin-lucca

Fixed. I don't get why but we omitted to add a class on description 🤷 Not breaking but it will be necessary for product teams to add this class to have a good spacing management. https://github.com/LuccaSA/lucca-front/pull/2774/commits/9c51b5069e92c5e5321964b359d72b9b79abc7c5

jeremie-lucca avatar May 16 '24 08:05 jeremie-lucca

:woman_cook: https://lucca-front.lucca.tech/PR-2774/storybook

LuccaIntegration avatar May 16 '24 08:05 LuccaIntegration

Tests d'interfaces

CCNET-iLucca avatar May 16 '24 08:05 CCNET-iLucca

:woman_cook: https://lucca-front.lucca.tech/PR-2774/storybook

LuccaIntegration avatar May 16 '24 09:05 LuccaIntegration

Tests d'interfaces

CCNET-iLucca avatar May 16 '24 09:05 CCNET-iLucca

:woman_cook: https://lucca-front.lucca.tech/PR-2774/storybook

LuccaIntegration avatar May 29 '24 10:05 LuccaIntegration

Tests d'interfaces

CCNET-iLucca avatar May 29 '24 10:05 CCNET-iLucca