Sorting-Algorithms-Visualizer icon indicating copy to clipboard operation
Sorting-Algorithms-Visualizer copied to clipboard

[BUG]Array size input validation

Open m3et opened this issue 3 years ago • 6 comments

Array Size input validation Input size is not validate causing program to crash when input size of array is to big ~100000000 or 0 or none labels: user-experience assignees: 'Self-assigned'

I will change the code to make validation on the size to be in range (0,500000)

image

m3et avatar Jun 07 '21 18:06 m3et

Thanks for reporting it! I appreciate your help.

LucasPilla avatar Jun 07 '21 18:06 LucasPilla

NP, I'm thinking about a assigning a defualt value if int() function throw an exception. let me now what you thik about this?

image

m3et avatar Jun 07 '21 18:06 m3et

Hey, this seemes to be working. image

Its kind of my first time so I'm not sure what should I do in order to make a pull request...

m3et avatar Jun 07 '21 19:06 m3et

@m3et Hello! You might find something if you search for how to open a pull request. If you have any problem let me know.

LucasPilla avatar Jul 19 '21 16:07 LucasPilla

Is this issue still open to fix or someone has already fixed it?

sandipan898 avatar Aug 19 '21 12:08 sandipan898

@sandipan898 The problem was fixed, just waiting for @m3et to open a pull request with his changes

LucasPilla avatar Aug 19 '21 13:08 LucasPilla