Lucas Demea
Lucas Demea
Thank you, I'll have a look at all this, this afternoon.
Do you mind if we replace the array_flatten method with [lodash.flatten](https://lodash.com/docs/#flatten), as it is already typed ?
Didn't know this one, thanks
One these lines https://github.com/adaltas/node-plug-and-play/blob/1f4b16b308a5e9e0706ce55fd4939d55dfc082f8/lib/index.js#L141-L143 We use the `plugin` property that is added to hooks a few lines before. 2 questions: - This property isn't available on all hooks. Hooks coming...
Thanks. This part is a pain to adapt to typescript, as it goes against TS strong typing practice. In the TS paradigm, we should not dynamically add properties to the...
Is the call_sync function still in use ? You don't speak about it in the docs nor in [your blog post](https://www.adaltas.com/en/2020/08/28/node-js-plugin-architecture/).
David, you should be able to fix and adapt the tests now. There is still some work at the typing level (some `any` types that we must get rid of)...
I'd like to hear your opinion about 2 things: - I updated the linting & formatting configs. I replaced the outdated eslint config with a prettierrc, trying to replicate your...
There are 2 things I'd like to bring your attention to, in the last (and supposedly final) changes. - I removed `args` and `hooks` default `= []` ([4def56c](https://github.com/adaltas/node-plug-and-play/pull/2/commits/4def56caa9c3cd2b01e0e04774f4588afe1353fd)) as it...
> > > I'd suggest to remove the build artifacts from the repo > > I am hesitant about this, if a CI does it automatically, new extra commits will...