pre-commit-hooks icon indicating copy to clipboard operation
pre-commit-hooks copied to clipboard

Published 20 hours ago • verified publisher icon Lucas-C

python-Levenshtein-wheels not available for python 3.10

Open daniela-winkler opened this issue 3 years ago • 5 comments

I recently upgraded my python version to 3.10 and found out that python-Levenshtein-wheels are not maintained anymore. To my knowledge there is a fork of this library with python 3.10 support: https://pypi.org/project/Levenshtein/ I would appreciate if you adapt the dependencies.

daniela-winkler avatar Aug 12 '22 15:08 daniela-winkler

This is related to #18 & #19

Based on the latest comment on https://github.com/ztane/python-Levenshtein/issues/61 I think we can go back to python-Levenshtein.

Would you like to submit a PR?

Lucas-C avatar Aug 13 '22 06:08 Lucas-C

Thank you for accepting my changes. Unfortunately, using python-Levenshtein causes problems for Windows users while everything works fine for Linux users. When using Windows, I'm able to install https://pypi.org/project/Levenshtein/. Would you mind if I adapt the dependencies (again)?

daniela-winkler avatar Aug 16 '22 10:08 daniela-winkler

Sure, feel free to submit a PR!

Also, if you are familiar with GitHub actions, adding a pipeline execution in a Windows would be very welcome to ensure compatibility with this OS is validated.

Lucas-C avatar Aug 16 '22 12:08 Lucas-C

now that 1.3.1 is tagged, this should be closed?

vfazio avatar Aug 16 '22 13:08 vfazio

now that 1.3.1 is tagged, this should be closed?

You are right, but given that the latest release seem to have caused issues for Windows users, I'm going to wait for PR #57 to be released before closing this.

Lucas-C avatar Aug 16 '22 13:08 Lucas-C

Fixed by https://github.com/Lucas-C/pre-commit-hooks/pull/58

Lucas-C avatar Mar 31 '23 08:03 Lucas-C