Luca D'Amico

Hi Vito, > What happens when you modify the colors in SoftICE? I mean, what color it uses to highlight a changed register value after executing the COLOR command? With...

Hi Vito, I'll comment your NOTES in reverse order :) > NOTE5: in the code, please replace "char current_colors[30];" with "CHAR currentColors[64];". Fixed! > NOTE4: maybe we should implement the...

Hi, I've done some research and I figured out that this should be the color conversion map: ``` 0 (black) -> F (white) 1 (blue) -> E (yellow) 2 (green)...

Hi @vitoplantamura sorry for the delay, I had a very busy week. So, I've fixed the highlight colors. I think this PR can now be considered complete (apart from the...

Hi @vitoplantamura I've just pushed the fixes, thanks! > You should not check for "Wnd::nrmClr != 0x07", but instead you should simply pick the value of "Wnd::nrmClr". > For example,...

Hi Vito > please remove the NegateByte method and replace it with these two methods: > eastl::string Utils::GetColor( BYTE clr ) > { > return HexToString(clr, sizeof(BYTE)); > } >...

Hi Vito, I'm experiencing an issue with the GetColorSpecial function. If I don't use the COLOR command, it works correctly (passing 0x0B will return "0x0B"), but once a custom color...

Hi Vito, I think your latest implementation of GetColorSpecial works fine :) I've been testing it for a while without any noticeable issues. I also removed the "*" from ParseListOfBytesArgs....

hi Vito, you are right, it is not used. Removed :) Thanks, Luca

The problem here is that Travis (our CI) is running Linux, and CxBx-Reloaded is currently Windows only. It might be possible to install wine, running tests and the upload the...