Add a quick-call left pane to the main window
Add address book ui for quick call. One click - select. Two - call. Some problem - in menu view translation for address book doesn't work.
To anyone else wondering what this is all about: This adds a vertical left pane, similar to the Buddy list, with the contents of the local address book. A single click will prefill the call input line with the contact's phone number (as if it had been selected from the Address book dialog), while a double click will automatically call that contact.
I guess this could be useful for people who find themselves calling their contacts very frequently, by lowering the number of clicks (and mouse movements) required to do so. Otherwise, I can't really comment on the desirability or design of this feature, so I'll let other people chime in. Likewise, I can't say much about its UI, although I might have some remarks about the functionality of it all.
What I can definitely say, however, is that this pull request is in no way, shape or form suitable for being merged in its current state. It's painfully obvious that its author did not bother looking at the file changes before submitting it. @RufusBarma, please click on the "Files changed" tab above and take the time to review the changes you are proposing. (I'll try to submit a review later on, but you should be able to easily spot most of the issues by yourself.)
(Just to be clear: this is not meant to offend you or dismiss your work. It's always great to see people willing to pitch in and contribute to a project. It's just that acting carelessly can result in wasted time and effort for everyone involved.)
@fbriere is there something more to do in the PR's or is it a problem with @LubosD that has no sufficient time to mantain/develop/review PR's /app.
Maybe fork is needed here to release a new version of the program, right? Anyways I have to say thanks to all the people involved, don't confuse with being angry or something, I am just pointing that I see more activity from the contributors now for whatever justified reason.
@fbriere is there something more to do in the PR's
I think that between the various issues I raised in my review above, the big red "Changes requested" indicator below, and my earlier comment stating that "this pull request is in no way, shape or form suitable for being merged in its current state", I think you're likely to find a few reasons why this PR has remained in its current state.
(If you want to talk about the state of the project in general, I suggest that this topic be kept within #206. Thanks.)