Paul Holzinger

Results 841 comments of Paul Holzinger

cc @edsantiago @mheon just an idea I had but I don't think it works as the client is killed before the server so I still try to figure out if...

> I will cherrypick onto https://github.com/containers/podman/pull/17831 as soon as the current run finishes No point actually, this commit will do nothing. If we time-out in cleanup ginkgo panics and we...

Ok this version might be good enough, but looking at this I really need to fix the cleanup logic there. One command times out and we leak stuff...

> [HTH](https://api.cirrus-ci.com/v1/artifact/task/5958505411117056/html/int-remote-rawhide-root-host-sqlite.log.html#t--Podman-kube-play-test-with-annotation-size-within-limits--1) ``` github.com/containers/podman/v5/libpod.(*ConmonOCIRuntime).UpdateContainerStatus(0xc000210000, 0xc000296000) /var/tmp/go/src/github.com[/containers/podman/libpod/oci_conmon_common.go:231](https://github.com/containers/podman/blob/c1ffa97d0cc2a568a61856f645f6f3c032b77e02/libpod/oci_conmon_common.go#L231) +0x40d fp=0xc0003e9920 sp=0xc0003e9730 pc=0x14a4a2d github.com/containers/podman/v5/libpod.(*ConmonOCIRuntime).killContainer(0xc000210000, 0xc000296000, 0xf, 0x0, 0x1) /var/tmp/go/src/github.com[/containers/podman/libpod/oci_conmon_common.go:386](https://github.com/containers/podman/blob/c1ffa97d0cc2a568a61856f645f6f3c032b77e02/libpod/oci_conmon_common.go#L386) +0x596 fp=0xc0003e9ab0 sp=0xc0003e9920 pc=0x14a6696 github.com/containers/podman/v5/libpod.(*ConmonOCIRuntime).StopContainer.func1(0x35838?) /var/tmp/go/src/github.com[/containers/podman/libpod/oci_conmon_common.go:415](https://github.com/containers/podman/blob/c1ffa97d0cc2a568a61856f645f6f3c032b77e02/libpod/oci_conmon_common.go#L415) +0x38 fp=0xc0003e9b40 sp=0xc0003e9ab0 pc=0x14a6ef8 github.com/containers/podman/v5/libpod.(*ConmonOCIRuntime).StopContainer(0xc000210000, 0xc000296000, 0xa, 0x0)...

The image is an OCI image and oci images do not have an healtcheck config so it is impossible to specify one there. I don't know what immich does but...

Mhh, looking at the oci spec it seems to list healtcheck as reserved in the config now, but only because docker uses it. It doesn't seem to be actually standardized,...

This is not an easy fix, generally speaking we abuse init() functions way to much and do to much work there. And we cannot parse the arguments earlier. But even...

A env var is an option, but then we still have to ensure somehow it is parsed first (easy enough if we just consider the config parsing code but not...

No, I don't have a issue but we have little to no control over the order of the imports and in what order init() runs. As such reading the env...

The big thing are all the cobra command definitions in cmd/podman/... that setup the commands and flags. They in turn the call out to a bunch of other function, i.e....