YouTube.js icon indicating copy to clipboard operation
YouTube.js copied to clipboard

feat: add TV client endpoints and nodes to get content with default OAuth2 Login

Open Duell10111 opened this issue 11 months ago • 11 comments

As reaction to the block of the classic TV OAuth authentication on non TV endpoints, I tried to add Helper classes with TV Client optimization. Related issue: https://github.com/LuanRT/YouTube.js/issues/803 As I am not an expert of the Innertube API and the Youtube.js library, feel free to optimize or bring up suggestions of this PR. Therefore this PR is created as draft. :)

Additionally regarding TV endpoints, I added a new function to adapt watched time for videos added to the watch list (history). (Issue: https://github.com/LuanRT/YouTube.js/issues/825)

Further for the TV client I added a helper function to get the continuation of HorizontalList as needed for the TV Homefeed. :)

Duell10111 avatar Jan 15 '25 17:01 Duell10111

Regarding the failing test, locally it works. ;)

Duell10111 avatar Jan 15 '25 17:01 Duell10111

Additionally please change the commit messages to say feat instead of chore, release please looks at the commit messages so if this were to be merged, then it would get logged as a chore and not a feature implementation.

absidue avatar Jan 15 '25 21:01 absidue

Thanks @absidue @LuanRT for all the suggestions I can split the PR into multiple and do the other changes as mentioned. I am a bit unsure when I can do this, because I have not much time until next week. But I will do this once I got time. :)

Duell10111 avatar Jan 16 '25 11:01 Duell10111

@Duell10111 This PR is quite large, so I'll be helping you with it very soon. I'm also interested in getting OAuth working again, but we may need to make improvements in a few places.

LuanRT avatar Jan 29 '25 11:01 LuanRT

@Duell10111 This PR is quite large, so I'll be helping you with it very soon. I'm also interested in getting OAuth working again, but we may need to make improvements in a few places.

Thank you, I would be glad to get help. Feel free to optimize or adapt it as you think. :D

Duell10111 avatar Jan 31 '25 23:01 Duell10111

Is there anything I could help with here to get some progress?

sgebr01 avatar May 05 '25 02:05 sgebr01

This PR has been automatically marked as stale because it has not had recent activity. Remove the stale label or comment or this will be closed in 2 days

github-actions[bot] avatar Jul 05 '25 02:07 github-actions[bot]

Can we do sth to get this merged? @LuanRT

Duell10111 avatar Jul 05 '25 09:07 Duell10111

@Duell10111 FYI there are still some open points from my last review (pinging you because your last commit was 20 days ago).

absidue avatar Jul 25 '25 08:07 absidue

@absidue Your open points should be handled now. :)

Duell10111 avatar Jul 27 '25 14:07 Duell10111

This PR has been automatically marked as stale because it has not had recent activity. Remove the stale label or comment or this will be closed in 2 days

github-actions[bot] avatar Oct 30 '25 02:10 github-actions[bot]